Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please make the gamerule cycle overrides an opt-in system #333

Open
ZestyBlaze opened this issue Nov 15, 2024 · 0 comments
Open

Please make the gamerule cycle overrides an opt-in system #333

ZestyBlaze opened this issue Nov 15, 2024 · 0 comments

Comments

@ZestyBlaze
Copy link

I've currently on owo-lib on a project because my project is using Accessories which has the lib embedded so it's in my project too while I'm working with Accessories.
My project relies heavily on the day night cycle and during trying to test my mod, owo defaulting the day/night cycle without any warning or to my knowledge, was causing me a lot of issues because it was causing me to believe that my mod was at fault.
My project in question I would test if my stuff was working by sleeping, but with the daynight cycle frozen, it was not working. Finally figured it out when I realised it was being set to false on world creation, and reverse searched it and saw owo doing this

Now this is my own opinion, but I usually create a lot of new worlds to make sure everything works okay, and having to basically opt back into a minecraft vanilla feature in my own dev environment is really annoying, and it caused me to waste 3-4 hours over a period of a couple days trying to hunt for what I was doing wrong. And I know if this is causing me an issue, it will probably cause others confusion or an issue at some point.
My only request is please make this an opt-in feature within the lib. Just something like in main mod constructor you can have Owo.freezeCyclesOnCreation() and it sets a boolean to true which lets these gamerules be set to default when the world is created. I can explain more but please consider this issue and suggestion

@ZestyBlaze ZestyBlaze changed the title Please make the gamerule sets opt-in Please make the gamerule cycle overrides an opt-in system Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant