Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash only reproducible if Minecraft freezes and you remove a parent component #224

Open
Zailer43 opened this issue Apr 11, 2024 · 1 comment
Assignees
Labels
priority: low this issue only has minor effects - adressing it is not immediately required status: confirmed this issue is reproducible or otherwise confirmed to exist type: bug this issue breaks or otherwise adversely affects functionality

Comments

@Zailer43
Copy link
Contributor

Description

I was with a friend on a server and he crashed using my mod, I asked him for the crash report, and from what I could notice, I can't reproduce it. Then he told me that Minecraft froze before the crash, which makes sense if we look at where it crashed. When calling the queue parent, it wasn't null, but inside the queue it was because while it froze, he clicked and closed an overlay that was the parent.

default void remove() {
if (!this.hasParent()) return;
this.parent().queue(() -> {
this.parent().removeChild(this);
});
}

Crash log

https://gist.github.com/Zailer43/dcac94e1897b86ab30a5eba98a0d54e3

Versions

owo-lib = 0.12.6+1.20.3
fabric-api = 0.96.1+1.20.4

@gliscowo gliscowo self-assigned this Apr 29, 2024
@gliscowo gliscowo added type: bug this issue breaks or otherwise adversely affects functionality priority: low this issue only has minor effects - adressing it is not immediately required status: confirmed this issue is reproducible or otherwise confirmed to exist labels Apr 29, 2024
@gliscowo
Copy link
Member

I can certainly see how this would happen, I'll probably just capture the parent at queue time and pass that into the actual task. Given how this is a rather non-critical problem though it might be a little while before I actually get around to implementing and publishing that

Either way, thanks for reporting!
Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: low this issue only has minor effects - adressing it is not immediately required status: confirmed this issue is reproducible or otherwise confirmed to exist type: bug this issue breaks or otherwise adversely affects functionality
Projects
None yet
Development

No branches or pull requests

2 participants