Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HorizontalPodAutoscaler to the v2 CRD #50

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

sebagomez
Copy link
Contributor

The helm chart fails to apply on "newer" versions of Kubernetes because autoscaling/v2beta is no longer available

References

https://kubernetes.io/docs/tasks/run-application/horizontal-pod-autoscale/#support-for-resource-metrics

Submitter checklist

  • [ x] Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • [ x] The PR request is well described and justified, including the body and the references
  • [ x] The PR title represents the desired changelog entry
  • [ x] The repository's code style is followed (see the contributing guide)
  • [ x] Test coverage that demonstrates that the change works as expected
  • [ x] For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@sebagomez sebagomez requested a review from gitkent as a code owner November 29, 2024 14:41
@gitkent
Copy link
Collaborator

gitkent commented Dec 2, 2024

@sebagomez thanks for your PR. Please check linting error in CI.

@DanielFran
Copy link
Contributor

@sebagomez @gitkent Maybe also update the chart with latest app version?
appVersion: "3.8.0" > appVersion: "3.10.0"?

@gitkent gitkent merged commit 6cbe032 into wiremock:master Dec 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants