Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support definition of mappings and responses in the values.yaml file #49

Merged
merged 2 commits into from
Sep 26, 2024

Conversation

subigre
Copy link
Contributor

@subigre subigre commented Sep 20, 2024

This PR implements the feature requested by @tom-intermedia in the issues #44, meaning it supports the definition of mappings and responses through the values.yaml file.

References

Closes #44

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@subigre subigre requested a review from gitkent as a code owner September 20, 2024 08:31
@subigre
Copy link
Contributor Author

subigre commented Sep 20, 2024

PS: I know that I put the same chart version in both PRs (this one and the #48), but I don't know which one will be merged first.
So, I will rebase and update the version to 1.3.0 in the one that will be merged at the end (or you can do it as well)

@gitkent
Copy link
Collaborator

gitkent commented Sep 23, 2024

PS: I know that I put the same chart version in both PRs (this one and the #48), but I don't know which one will be merged first. So, I will rebase and update the version to 1.3.0 in the one that will be merged at the end (or you can do it as well)

The other PR has been merged. Please rebase this one and bump the chart version. thanks

@subigre subigre force-pushed the 44-mappings-responses branch from 4e7678c to 837dfd2 Compare September 24, 2024 06:31
@subigre subigre force-pushed the 44-mappings-responses branch from 837dfd2 to d823f7b Compare September 24, 2024 06:36
@subigre
Copy link
Contributor Author

subigre commented Sep 24, 2024

It is done!

@gitkent gitkent merged commit eb2b411 into wiremock:master Sep 26, 2024
1 check passed
@subigre subigre deleted the 44-mappings-responses branch September 26, 2024 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support the definition of mappings and responses in values files
2 participants