fix: Applied filter view height - WPB-14421 #2188
Open
+4
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: product-roadmap
Test Results1 783 tests 1 780 ✅ 3m 3s ⏱️ For more details on these failures, see this check. Results for commit 3edb207. ♻️ This comment has been updated with latest results. |
samwyndham
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Currently the view surrounding the filter description label & remove filter button has an erratic height. See videos below. This PR fixes it by adding vertical padding of 8 points padding around the description label. This matches the design as best I reasonably can.
Interestingly in Simulator things look fine. The issue only shows on device.
Note: The conversation list has many auto layout warnings being logged making it hard to debug this kind of issue and hard to know we are not making things wore. As far as I could tell this fix did not result in more warnings. We should find time to fix these warnings though.
Current behavior
ScreenRecording_11-22-2024.15-43-35_1.MP4
Fixed behavior
ScreenRecording_11-22-2024.15-43-07_1.MP4
Testing
Checklist
[WPB-XXX].