feat: Change a key for the dependency cache - WPB-14445 #2180
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: technical-roadmap/throughput
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 76e4442. ♻️ This comment has been updated with latest results. |
caldrian
approved these changes
Nov 21, 2024
| @@ -168,7 +168,7 @@ jobs: | |||
| uses: actions/cache@v3 | |||
| with: | |||
| path: ${{ env.PACKAGES_DIR }} | |||
| key: ${{ runner.os }}-swiftpm-project-${{ hashFiles('**/*.xcworkspace/xcshareddata/swiftpm/Package.resolved') }} | |||
| key: ${{ runner.os }}-swiftpm-project-${{ hashFiles('**/*.xcworkspace/xcshareddata/swiftpm/Package.resolved') }}-true | |||
There was a problem hiding this comment.
Looks good, however, I'm not sure if it should be false instead.
There was a problem hiding this comment.
I thought the default ENABLE_DATADOG value is true, but I think it shouldn't be a problem to use cache with DD.
There was a problem hiding this comment.
for running tests I would say false also. ENABLE_DATADOG is not defined here
KaterinaWire
changed the title
netbe
requested changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
We create a key for the cache when building the app as:
hash(Package.resolved)-ENABLE_DATADOGBut for tests we can hardcode the value of
ENABLE_DATADOG, and this will allow the cache to be reused.Testing
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: