Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove option to select protocol in create group - WPB-10442 #2148

Open
wants to merge 10 commits into
base: develop
Choose a base branch
from

Conversation

KaterinaWire
Copy link
Contributor

@KaterinaWire KaterinaWire commented Nov 11, 2024

BugWPB-10442 Remove option to select protocol in create group

Issue

By default, we should not see the selection of protocols when creating a conversation. However, this should be possible for testing.

Testing

By default, the option to select a protocol when creating a group should be hidden.

Needs to release with

  • [ https://github.com/wireapp/wire-ios-build-assets/pull/130 ]

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: unplanned Any work item that isn’t part of the product or technical roadmap. label Nov 11, 2024
Copy link
Contributor

github-actions bot commented Nov 12, 2024

Test Results

    3 files    335 suites   2m 34s ⏱️
2 066 tests 2 066 ✅ 0 💤 0 ❌
2 074 runs  2 074 ✅ 0 💤 0 ❌

Results for commit 06f6836.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see removing MLS_ENABLED following the PR in wire-ios-build-assets + updating the submodule ref.
@KaterinaWire do you plan another PR for this?

@KaterinaWire
Copy link
Contributor Author

I don't see removing MLS_ENABLED following the PR in wire-ios-build-assets + updating the submodule ref. @KaterinaWire do you plan another PR for this?

@netbe I'm removing MLS_ENABLED in #2129

I will update the submodule ref when PR for wire-ios-build-assets is merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE echoes: unplanned Any work item that isn’t part of the product or technical roadmap.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants