refactor: conversation message timer update event - WPB-10171 #2098
+580
−154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jullianm
commented
Oct 29, 2024
| @@ -59,25 +58,29 @@ public protocol ConversationLocalStoreProtocol { | |||
| /// - Parameter isFederationEnabled: A flag indicating whether a `Federation` is enabled. | |||
|
|
|||
| func storeConversation( | |||
| _ conversation: WireAPI.Conversation, | |||
| _ conversation: WireDomain.Conversation, | |||
There was a problem hiding this comment.
94b4ad4 introduces a WireDomain conversation object that replaces the WireAPI.Conversation object passed as parameter here to avoid introducing API layer elements in our local stores. (local stores should be agnostic of the API layer).
jullianm
commented
Oct 29, 2024
| remoteConversation: WireAPI.Conversation, | ||
| remoteConversationID: UUID, | ||
| from conversation: Conversation, | ||
| withID id: UUID, |
There was a problem hiding this comment.
many changes like this in this PR: renaming parameters for more clarity
jullianm
commented
Oct 29, 2024
| @@ -173,7 +173,7 @@ public final class ConversationRepository: ConversationRepositoryProtocol { | |||
| } | |||
|
|
|||
| await conversationsLocalStore.storeConversation( | |||
| conversation, | |||
| conversation.toDomainModel(), | |||
There was a problem hiding this comment.
preparing data for the local store by converting the API object to a Domain object.
netbe
reviewed
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key points
This PR is part of the quick sync refactoring plan and is related to processing the multiple events we receive from the backend or the push channel.
Specifically, this PR is about porting the existing implementation of the
ConversationMessageTimerUpdateevent.Testing
UTs cover the following use cases, ensuring that
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: