Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: move WireLogger into WireFoundation - WPB-11881 #1938

Draft
wants to merge 308 commits into
base: release/cycle-3.114
Choose a base branch
from
Draft

chore: move WireLogger into WireFoundation - WPB-11881 #1938

wants to merge 308 commits into from
+276 −794

Conversation

caldrian
Copy link
Contributor

@caldrian caldrian commented Sep 16, 2024 •
edited by github-actions bot
Loading

StoryWPB-10941 Create WireFoundation package combining WireSystem, WireUtilities and WireTesting

Issue

In order to be able to use logging from WireFoundation the Wire Logger must be declared here.
This PR moves all files except WireLoggerObjC to WireFoundation.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@caldrian
add IDETemplateMacros.plist
4c7aa52
@caldrian
create symlinks
fadb05c
@caldrian
create WireSystemPackage
b586954
@caldrian
code style
f63c45a
@caldrian
create WireUtilitiesPackage
58c0e1e
@caldrian
dynamic frameworks
b60e63d
@caldrian
fix workflows
502673f
@caldrian
prepare merging branches
d76fd10
@caldrian
Merge branch 'chore/move-WireUITesting-into-separate-package-WPB-7306…
6a60e87 
…' into chore/create-swift-package-for-wire-system-WPB-7306

# Conflicts:
#	.swiftformat
#	SourceryPlugin/.swiftpm/xcode/package.xcworkspace/xcshareddata/WorkspaceSettings.xcsettings
#	WireAPI/Package.resolved
@caldrian
delete temporary code
a6f4aec
@caldrian
undo changes
7383a5d
@caldrian
fix workflow definition
ab4ea4c
@caldrian
minor fix
261f652
@caldrian
PrivacyInfo.xcprivacy
027352e
@caldrian
prepare Sourcery integration
4b03cc8
@caldrian
create package WireDomainPackage
0e89d17
@caldrian
fix workflow files
be2db8d
@caldrian
link WireDomainPackage into WireDomain
2d70bca
@caldrian
cleanup
61737ca
@caldrian
format code
9b694ae
@caldrian
change directory structure for WireUtilitiesPackage
7b3ce68
@caldrian
move project WireDomain
94ed28b
@caldrian
fix linking WireAPI
b1a95ef
@caldrian
update projects
0a05c3e
@caldrian
merge WireDomain directories
b819d15
@caldrian
rename projects
db5c566
@caldrian
fix directory structure for WireSystem
48716df
@caldrian
fix directory structure for WireUtilities
0192d95
@caldrian
fix directory structure for WireTesting
e812ace
@caldrian
fix workspace
618025d
caldrian and others added 28 commits November 21, 2024 23:33
@caldrian
add missing imports
3259660
@caldrian
attempt to fix linker error
353fbde
@caldrian
fix WireSystem file localtions
b8bc589
@caldrian
clean up WireUtilitiesPackage
ec15f07
@caldrian
fix package import
ded123c
@caldrian
Trigger CI
e0b3991
@caldrian
Merge branch 'chore/cleanup-redundant-swift-packages-WPB-10368' into …
c75f01d 
…chore/move-WireLogger-into-WireFoundation-WPB-10941
@caldrian
Merge branch 'release/cycle-3.114' into chore/cleanup-redundant-swift…
fbf33ba 
…-packages-WPB-10368
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
b8eeb6e 
…o chore/cleanup-redundant-swift-packages-WPB-10368
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
e2490d3 
…o fix/sourcery-stencils-WPB-11881

# Conflicts:
#	WireFoundation/Sources/WireSystemSupport/Sourcery/sourcery.yml
@caldrian
add TODOs
2f6cf6b
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
14f9dff 
…o fix/sourcery-stencils-WPB-11881
@caldrian
link WireFoundation into WireUtilitiesTests
e76b310
@caldrian
prepare moving CocoaLumberjackLogger to common components
5e6a438
@caldrian
Merge branch 'release/cycle-3.114' of github.com:wireapp/wire-ios int…
a381ce0 
…o chore/cleanup-redundant-swift-packages-WPB-10368
@caldrian
Merge branch 'chore/cleanup-redundant-swift-packages-WPB-10368' into …
7ee8ee4 
…chore/move-WireLogger-into-WireFoundation-WPB-10941
@caldrian
move CocoaLumberjackLogger to common components
a47b9f2
@caldrian
link WireFoundation into WireUtilitiesTests
530a4ab
@caldrian
cleanup
14f1919
@caldrian
undo adding imports
d839829
@caldrian
undo project file changes
1918d02
@caldrian
minor fix
df1084d
@caldrian
Merge branch 'release/cycle-3.114.tmp' into fix/sourcery-stencils-WPB…
88c48cf 
…-11881
@caldrian
Merge branch 'fix/sourcery-stencils-WPB-11881' into chore/move-WireLo…
120b6d7 
…gger-into-WireFoundation-WPB-10941
@caldrian
fix build error
43d8af1
@caldrian
Merge branch 'fix/sourcery-stencils-WPB-11881' into chore/move-WireLo…
9b41d8e 
…gger-into-WireFoundation-WPB-10941
@caldrian
fix imports
77a18eb
@caldrian
link WireFoundation into WireTransport
f9d8195
@caldrian caldrian changed the base branch from release/cycle-3.114 to fix/sourcery-stencils-WPB-11881 November 22, 2024 14:55
Base automatically changed from fix/sourcery-stencils-WPB-11881 to release/cycle-3.114 November 22, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@netbe netbe netbe left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@caldrian caldrian

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. echoes: technical-roadmap/technical-debt Changes intended at mitigating risks echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes: unplanned Any work item that isn’t part of the product or technical roadmap. WIP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caldrian @netbe