feat: refactor CI tests - WPB-11406 #1707
Open
+719
−682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o chore/unify-schemes-and-testplans-WPB-11406
…refactor-ci-tests # Conflicts: # .github/workflows/_reusable_run_tests.yml # .github/workflows/test_pr_changes.yml
Base automatically changed from
chore/unify-schemes-and-testplans-WPB-11406
to
release/cycle-3.114
November 28, 2024 08:34
…o chore/unify-schemes-and-testplans-WPB-11406
…refactor-ci-tests
caldrian
reviewed
Nov 28, 2024
6 tasks
netbe
commented
Nov 29, 2024
| uses: 8398a7/action-slack@v3 | ||
| with: | ||
| status: ${{ job.status }} | ||
| text: "🆘 Tests for 'develop' failed 🆘\ncommit: https://github.com/wireapp/wire-ios-mono/commit/${{ github.sha }}\n**Triggered by:** ${{ github.triggering_actor }}\n**Build log:** ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}\n" | ||
| text: "🆘 Tests for '${{ github.ref_name }}' failed 🆘\ncommit: https://github.com/wireapp/wire-ios-mono/commit/${{ github.sha }}\n**Triggered by:** ${{ github.triggering_actor }}\n**Build log:** ${{ github.server_url }}/${{ github.repository }}/actions/runs/${{ github.run_id }}\n" |
There was a problem hiding this comment.
change this message because it might be green + different channel "Nightly tests" + check github.sha
fastlane/framework.rb
Outdated
| when "wire-ios" | ||
| "Wire-iOS" | ||
| when "WireFoundation" | ||
| "WireFoundationAll" # use a custom scheme that includes all targets of WireFoundation |
There was a problem hiding this comment.
WireFoundation-Package
There was a problem hiding this comment.
this cannot work so I had to duplicate the scheme
| env: | ||
| GITHUB_ACCESS_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GITHUB_USERNAME: ${{ secrets.ZENKINS_USERNAME }} | ||
| SLACK_WEBHOOK_URL: ${{ secrets.WIRE_IOS_CI_WEBHOOK }} | ||
| SLACK_WEBHOOK_URL: ${{ secrets[inputs.notify_secret] }} |
There was a problem hiding this comment.
different channel depending on parent workflow
There was a problem hiding this comment.
added this file because it does not work with WireFoundation-Package with Fastlane
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
This PR allows to test all related frameworks when touching a framework on a PR. Previously it was not running tests of frameworks having the dependency.
It also moves the develop tests that are run when a PR is merged to be run nightly at 21:00.
bundle exec fastlane select_frameworksTODO
Testing
Running PR as a test
Checklist
[WPB-XXX].