Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add on profile account details btn WPB-970 #3654

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

damian-kaczmarek
Copy link
Contributor

@damian-kaczmarek damian-kaczmarek commented Nov 21, 2024

StoryWPB-970 Navigating from user profile to account settings


PR Submission Checklist for internal contributors

What's new in this PR?

Solutions

  • add account details button on self profile
  • changed buttons style according to the designs, removed shadow and button box elevation
  • changed from team name to @ userHandle@domain in accounts list
  • renamed colour dividerPersonalToTeamMigration to dividerNew as it uses the same divider colours, the current divider colour is used in strange places so I left is as is. Using the divider colour would cause for a Divider to not be visible in dark mode
  • changed new team string

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before After
image image

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@damian-kaczmarek damian-kaczmarek self-assigned this Nov 21, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 21, 2024
@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 21, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.04%. Comparing base (7cd4bd6) to head (7068787).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3654      +/-   ##
===========================================
+ Coverage    46.00%   46.04%   +0.04%     
===========================================
  Files          472      472              
  Lines        16093    16108      +15     
  Branches      2664     2665       +1     
===========================================
+ Hits          7403     7417      +14     
  Misses        7917     7917              
- Partials       773      774       +1     
Files with missing lines Coverage Δ
...tlin/com/wire/android/mapper/OtherAccountMapper.kt 85.71% <100.00%> (ø)
...id/ui/userprofile/self/SelfUserProfileViewModel.kt 56.71% <100.00%> (ø)
.../android/ui/userprofile/self/model/OtherAccount.kt 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cd4bd6...7068787. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Contributor

Built wire-android-staging-compat-pr-3654.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3654.apk is available for download

Copy link

sonarcloud bot commented Nov 22, 2024

Copy link
Contributor

Built wire-android-staging-compat-pr-3654.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3654.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants