Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add and remove conversation favorite [WPB-11639] #3653

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

feat: add and remove conversation favorite [WPB-11639] #3653

wants to merge 4 commits into from
+414 −61

Conversation

Garzas
Copy link
Contributor

@Garzas Garzas commented Nov 21, 2024

PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³

  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • implemented adding conversation to favorites folder
  • implemented removing conversation from favorite folder
  • extracted favorite add/remove management to smaller view model to not duplicate it in 3 places (OtherUserScreen, ConversationDetailsScreen, ConversationListScreen)
add_to_favorites.mov

@Garzas Garzas self-assigned this Nov 21, 2024
@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

saleniuk
saleniuk approved these changes Nov 21, 2024
View reviewed changes
app/src/main/kotlin/com/wire/android/ui/common/bottomsheet/conversation/HomeSheetContent.kt
@Composable
internal fun ConversationMainSheetContent(
conversationSheetContent: ConversationSheetContent,
// TODO(profile): enable when implemented
// addConversationToFavourites: () -> Unit,
changeFavoriteState: (dialogState: GroupDialogState, addToFavorite: Boolean) -> Unit,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion: move the // TODO(profile): enable when implemented line below this one so that it's right next to commented line // moveConversationToFolder: () -> Unit,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saleniuk saleniuk saleniuk approved these changes

@vitorhugods vitorhugods vitorhugods approved these changes

@yamilmedina yamilmedina Awaiting requested review from yamilmedina

@borichellow borichellow Awaiting requested review from borichellow

@damian-kaczmarek damian-kaczmarek Awaiting requested review from damian-kaczmarek

Assignees

@Garzas Garzas

Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Garzas @vitorhugods @saleniuk