Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adjust accessibility strings for personal to team migration feature (WPB-14347) #3651

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 20, 2024

TaskWPB-14347 [Android] accessibility strings – Personal to team migration


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

We need to adjust accessibility strings to be more clear for the user.
Also, I fixed some UI issues: continue button is covered by bottomNavigationBar and "create team" button is cut

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

Copy link
Contributor

Built wire-android-staging-compat-pr-3651.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3651.apk is available for download

…untMigration-accessiblity

# Conflicts:
#	app/src/main/kotlin/com/wire/android/ui/userprofile/teammigration/TeamMigrationState.kt
Copy link

sonarcloud bot commented Nov 22, 2024

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.04%. Comparing base (c911271) to head (c7f4b28).

Files with missing lines Patch % Lines
...serprofile/teammigration/TeamMigrationViewModel.kt 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3651   +/-   ##
========================================
  Coverage    46.04%   46.04%           
========================================
  Files          472      472           
  Lines        16108    16110    +2     
  Branches      2666     2666           
========================================
+ Hits          7417     7418    +1     
- Misses        7917     7918    +1     
  Partials       774      774           
Files with missing lines Coverage Δ
...ui/userprofile/teammigration/TeamMigrationState.kt 100.00% <100.00%> (ø)
...serprofile/teammigration/TeamMigrationViewModel.kt 94.87% <0.00%> (-2.50%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c911271...c7f4b28. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Contributor

Built wire-android-staging-compat-pr-3651.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3651.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants