fix: big padding around reaction pills #WPB-12094 #WPB-14269

[damian-kaczmarek]

WPB-12094 [Android] Gap between reactions when they go to next line

What's new in this PR?

Issues

Too big padding around reactions. Other changes are just cutting the RegularMessageItem into more files as detekt was triggered.

Causes (Optional)

Our override of minimal size used for accessibility got deprecated .

Solutions

Replaced with minimal size unspecified.

Also replaced in one other place, although I don't think it mattered there.

Testing

Test Coverage (Optional)

This kind of UI bugs could be easy to spot in golden tests, so I added previews

How to Test

Add many different reactions to the single message to the point it wraps around the screen.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)

Before	After

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 45.95%. Comparing base (6f753e9) to head (81ce83e).
Report is 6 commits behind head on develop.

Files with missing lines	Patch %	Lines
.../conversations/messages/item/SwipableToReplyBox.kt	0.00%	4 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3643   +/-   ##
========================================
  Coverage    45.95%   45.95%           
========================================
  Files          472      473    +1     
  Lines        16079    16079           
  Branches      2666     2661    -5     
========================================
  Hits          7389     7389           
  Misses        7909     7909           
  Partials       781      781           

Files with missing lines	Coverage Δ
.../kotlin/com/wire/android/ui/edit/ReactionOption.kt	0.00% <ø> (ø)
...oid/ui/home/conversations/messages/ReactionPill.kt	0.00% <ø> (ø)
.../conversations/messages/item/RegularMessageItem.kt	0.00% <ø> (ø)
.../conversations/messages/item/SwipableToReplyBox.kt	0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f753e9...81ce83e. Read the comment docs.

---- 🚨 Try these New Features:

• Flaky Tests Detection - Detect and resolve failed and flaky tests

[saleniuk]

Now I realised it's still a "draft", but my suggestions can still be helpful at this point 😅

[github-actions]

Built wire-android-staging-compat-pr-3643.apk is available for download

[github-actions]

Built wire-android-dev-debug-pr-3643.apk is available for download

[sonarcloud]

Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[github-actions]

Built wire-android-staging-compat-pr-3643.apk is available for download

[github-actions]

Built wire-android-dev-debug-pr-3643.apk is available for download