Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add setTranslatableUseFallback() - deprecate noFallbackLocale() #69

Merged
merged 1 commit into from
Mar 18, 2024
Merged

Add setTranslatableUseFallback() - deprecate noFallbackLocale() #69

merged 1 commit into from
Mar 18, 2024

Conversation

matteotrubini
Copy link
Contributor

closes #66

@mjauvin mjauvin self-assigned this Jun 9, 2023
@mjauvin mjauvin added this to the v2.1.5 milestone Jun 9, 2023
tests/unit/behaviors/TranslatableCmsObjectTest.php Outdated Show resolved Hide resolved
tests/unit/behaviors/TranslatableModelTest.php Outdated Show resolved Hide resolved
tests/unit/behaviors/TranslatablePageTest.php Outdated Show resolved Hide resolved
traits/MLControl.php Show resolved Hide resolved
@LukeTowers
Copy link
Member

What is the value add here?

@mjauvin
Copy link
Member

mjauvin commented Jun 16, 2023

@matteotrubini can you fix the unit tests, please?

@matteotrubini
Copy link
Contributor Author

@mjauvin honestly I don't know what is the correct way to declare the return type or if in this case should be left as undefined.

Copy link
Member

@mjauvin mjauvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Try this

classes/TranslatableBehavior.php Outdated Show resolved Hide resolved
classes/TranslatableBehavior.php Outdated Show resolved Hide resolved
@mjauvin
Copy link
Member

mjauvin commented Mar 18, 2024

@matteotrubini did you want to finish this or should I close this?

@mjauvin mjauvin removed this from the v2.1.5 milestone Mar 18, 2024
@mjauvin mjauvin closed this Mar 18, 2024
@matteotrubini
Copy link
Contributor Author

@mjauvin if failing return types can be left undefined tests will go green.

@mjauvin
Copy link
Member

mjauvin commented Mar 18, 2024

@matteotrubini Did you try with the suggested changes I made above ?

@mjauvin mjauvin reopened this Mar 18, 2024
@matteotrubini
Copy link
Contributor Author

I've tried "self" before, but it too failed tests, leaving me at a dead end.

@mjauvin
Copy link
Member

mjauvin commented Mar 18, 2024

I've tried "self" before, but it too failed tests, leaving me at a dead end.

@matteotrubini Ok, remove the retun signature then.

@matteotrubini
Copy link
Contributor Author

@mjauvin done!
I'm sorry for the multiple force-pushed, but I'm away from office and I'm playing with codespaces for the first time

@mjauvin mjauvin merged commit 78710da into wintercms:main Mar 18, 2024
3 checks passed
@mjauvin mjauvin added this to the v2.1.5 milestone Mar 18, 2024
@mjauvin
Copy link
Member

mjauvin commented Mar 18, 2024

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

noFallbackLocale inverse method
3 participants