-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add setTranslatableUseFallback() - deprecate noFallbackLocale() #69
Conversation
What is the value add here? |
@matteotrubini can you fix the unit tests, please? |
@mjauvin honestly I don't know what is the correct way to declare the return type or if in this case should be left as undefined. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Try this
@matteotrubini did you want to finish this or should I close this? |
@mjauvin if failing return types can be left undefined tests will go green. |
@matteotrubini Did you try with the suggested changes I made above ? |
I've tried "self" before, but it too failed tests, leaving me at a dead end. |
@matteotrubini Ok, remove the retun signature then. |
@mjauvin done! |
Thanks! |
closes #66