Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Save / Restore initial list showTree config value #987

Merged
merged 1 commit into from
Oct 14, 2023
Merged

Save / Restore initial list showTree config value #987

merged 1 commit into from
Oct 14, 2023

Conversation

mjauvin
Copy link
Member

@mjauvin mjauvin commented Oct 11, 2023 •
edited
Loading

Without this, Lists with showTree=true lose their Tree view when the search term is cleared.

This can easily be reproduced in the Winter.Test plugin under the Trees controller.

@mjauvin mjauvin added maintenance PRs that fix bugs, are translation changes or make only minor changes needs review Issues/PRs that require a review from a maintainer labels Oct 11, 2023
@mjauvin mjauvin added this to the v1.2.4 milestone Oct 11, 2023
@mjauvin mjauvin self-assigned this Oct 11, 2023
@LukeTowers LukeTowers added Status: Completed and removed needs review Issues/PRs that require a review from a maintainer labels Oct 14, 2023
@LukeTowers LukeTowers merged commit 8f7c656 into develop Oct 14, 2023
12 checks passed
@LukeTowers LukeTowers deleted the fix-lists-tree-search branch October 14, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukeTowers LukeTowers Awaiting requested review from LukeTowers

@bennothommo bennothommo Awaiting requested review from bennothommo

Assignees

@mjauvin mjauvin

Labels
maintenance PRs that fix bugs, are translation changes or make only minor changes
Projects
None yet
Milestone
v1.2.4
Development

Successfully merging this pull request may close these issues.
2 participants
@mjauvin @LukeTowers