Initial WIP on adding support for a partialExists function. #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently not mergeable because it still has a leftover effect of setting the componentContext and __SELF__ on the controller vars even when only calling findPartial() for component partials. Need to come up with a fix for that before this can be merged. Also need docs PR. Fixes #263.
|
This pull request will be closed and archived in 3 days, as there has been no activity in this pull request for the last 6 months. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently not mergeable because it still has a leftover effect of setting the componentContext and SELF on the controller vars even when only calling findPartial() for component partials. Need to come up with a fix for that before this can be merged. Also need docs PR.
Fixes #263.