Added soft deleting to Backend User Groups #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
softDelete option should not be added to the UserGroup model relation, only to User model relation |
|
@mjauvin Removed/reverted |
|
Waiting for wintercms/storm#156 to be merged. |
arvislacis
changed the title
mjauvin
added
Status: Completed
maintenance
LukeTowers
added a commit
to wintercms/storm
that referenced
this pull request
Oct 18, 2023
Adds support for automatic detaching / deletion of relationships using pivot tables. Related: wintercms/winter#386, wintercms/winter#972. Documented by wintercms/docs#159. Co-authored-by: Ben Thomson <[email protected]> Co-authored-by: Luke Towers <[email protected]>
|
@arvislacis can you test if applying this PR properly fixes the issue with Storm's develop branch? @LukeTowers or @bennothommo will merge this if it does. |
|
@mjauvin Yes, I can confirm that applying this PR and the latest changes from winter/storm develop branch fixes the issue. |
|
@bennothommo @LukeTowers we can merge this one and close its associated issue (#386) |
LukeTowers
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tries to solve #386
Depends on wintercms/storm#156 PR