Enable framework extras in backend #1234
Conversation
mjauvin
added
the
needs review
|
@mjauvin does this cause any duplication / double handling of existing backend functionality? |
|
@LukeTowers I checked thoroughly and there is no duplication whatsoever. |
|
I just realized there may be a need to also include the extras css as well... will check asap and report back here. |
|
Ok, so the extras styles are already contained in |
|
@bennothommo what was the reason you included |
|
@mjauvin the backend build of Snowboard does use some utilities that need styling (Flash, Stripe Loader, Transition). Also, I'm thinking it might be better that we try and hook up the original AJAX framework's events to Snowboard, and use the Snowboard Attach Loading utility instead. Should hopefully be doable. |
bennothommo
removed
the
needs review
|
I've submitted an alternate way of handling this - #1235. I've seen one plugin manually including the |
bennothommo
added
the
maintenance
|
@jaxwilko any thoughts? |
Replaces #1234, fixes #1233. Instead of loading framework.extras.css, which appears to be excluded from the Backend, this PR hooks the necessary original AJAX framework events into Snowboard's events, allowing the applicable events to execute UI functionality such as data-attach-loading and the Stripe loader. This is technically a stop-gap solution for now, since it doesn't emulate a full Snowboard request, so there's the potential for custom Snowboard event listeners to break if they are relying on Snowboard request information, but I'm not aware of that happening yet in core.
|
replaced by #1235 |
mjauvin
added
duplicate
Fixes #1233