Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: testing #315

Closed
wants to merge 25 commits into from
Closed

WIP: testing #315

wants to merge 25 commits into from

Conversation

Chriscbr
Copy link
Contributor

@Chriscbr Chriscbr commented Aug 30, 2024

Trying to root cause why wing gen-docs is hanging for @winglibs/k8s inside CI/CD

@Chriscbr
Copy link
Contributor Author

Chriscbr commented Aug 30, 2024

Through some imprecise debugging, it seems like I was able to narrow down that the issue of hanging comes up whenever there is a lib/ directory inside of the project. To be honest, there's no clear explanation for why this causes a problem. The issue seems to be specific to the GitHub runners (I'm unable to reproduce it locally) and I'm also unable to figure out why it only happens with the wing gen-docs command.

However, from the logging I was able to add, it seems like the hanging is happening while "preopening" files for the WebAssembly module. https://github.com/winglang/wing/blob/b9764935a94c38a561e6c9ac5f454976f2d86d7d/libs/wingcompiler/src/wingc.ts#L82 Perhaps it's trying to "preopen" all files from the file system?

I have an idea for a small patch that might update the relevant behavior so the CLI doesn't try opening as many files. Alas, I'm not sure if it will fix the issue, but we can try and see.

@Chriscbr
Copy link
Contributor Author

Chriscbr commented Aug 30, 2024

If my understanding of the root cause is correct, I'd categorize this as a type of bug that likely could have been avoided if we didn't have to use WebAssembly as an intermediary between the CLI and compiler.

@Chriscbr
Copy link
Contributor Author

The issue has been fixed with #7061 - reran the release workflow here (https://github.com/winglang/winglibs/actions/runs/10636846595/job/29498287120) and the new version of k8s with docs has been published.

@Chriscbr Chriscbr closed this Aug 30, 2024
@Chriscbr Chriscbr deleted the rybickic/fix-k8s-hanging branch August 30, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant