Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I want to update this branch to UE4 4.19 ,do you have any suggestion? #2

Open
Lz15984878289 opened this issue Mar 30, 2018 · 8 comments

Comments

@Lz15984878289
Copy link

I find a problem with UE4 4.18 that when creating a new C++ project.It can not open visual studio 2017 .So I want to update this branch to UE4 4.19.Can you tell me how did you merge this branch to UE4 4.18?Thanks very much

@windystrife
Copy link
Owner

i used VS 2015, i think it's stable for custom build now 😄

@Lz15984878289
Copy link
Author

I have find the problem where it is.
In this file:\Engine\Source\Programs\UnrealBuildTool\Platform\Windows\UEBuildWindows.cs.

` // Second, default based on what's installed, test for 2015 first
DirectoryReference VCInstallDir;

if (TryGetVCInstallDir(WindowsCompiler.VisualStudio2015, out VCInstallDir))
{
    return WindowsCompiler.VisualStudio2015;
}
if (TryGetVCInstallDir(WindowsCompiler.VisualStudio2017, out VCInstallDir))
{
    return WindowsCompiler.VisualStudio2017;
}

`
and if you have installed VS2017 but didn't install VS2015
this functionalso return true.

TryGetVCInstallDir(WindowsCompiler.VisualStudio2015, out VCInstallDir)

So I have change the order of these function ,like this
` // Second, default based on what's installed, test for 2017 first
DirectoryReference VCInstallDir;

    if (TryGetVCInstallDir(WindowsCompiler.VisualStudio2017, out VCInstallDir))
    {
        return WindowsCompiler.VisualStudio2017;
    }
      if (TryGetVCInstallDir(WindowsCompiler.VisualStudio2015, out VCInstallDir))
    {
        return WindowsCompiler.VisualStudio2015;
    }

`
And it works well now.

@Lz15984878289
Copy link
Author

By the way, in your branch,it has lost some files of Flex because of the gitignore file.Maybe you can add it.

@windystrife
Copy link
Owner

i don't see any missing flex files yet, can you show me??

@Lz15984878289
Copy link
Author

The flex editor lost a icon file.
you can get it there :
https://github.com/NvPhysX/UnrealEngine/tree/FleX-4.17.1/Engine/Content/Editor/Slate/Icons

@HypnosVR
Copy link

Any update to make this in UE4.19???

@Zimbower
Copy link

so excited about getting this to UE4.20

@kalng
Copy link

kalng commented Aug 24, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants