Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WARNING export 'withTooltipPropTypes' (imported as 'vxTooltipPropTypes') was not found #208

Open
schwannden opened this issue May 17, 2021 · 8 comments

Comments

@schwannden
Copy link

I have the following dependency in package.json

"@data-ui/xy-chart": "^0.0.84",
"@vx/tooltip": "^0.0.192"

When running yarn start (compiling the project), webpack gives warning

WARNING in ./node_modules/@data-ui/shared/esm/enhancer/WithTooltip.js 3:60-78
export 'withTooltipPropTypes' (imported as 'vxTooltipPropTypes') was not found in '@vx/tooltip/build/tooltips/TooltipWithBounds' (possible exports: __esModule, default)
 @ ./node_modules/@data-ui/shared/esm/index.js 1:71-151 1:71-151 1:71-151
 @ ./node_modules/@data-ui/xy-chart/esm/chart/XYChart.js 11:0-46 301:33-44
 @ ./node_modules/@data-ui/xy-chart/esm/index.js 2:0-84 2:0-84 2:0-84
...

And This line of import seems indeed to be invalid:

withTooltipPropTypes as vxTooltipPropTypes,

considering that withTooltipPropTypes really is not found in tooltip package: https://github.com/airbnb/visx/blob/master/packages/visx-tooltip/src/tooltips/TooltipWithBounds.tsx

@phenry2
Copy link

phenry2 commented Jul 2, 2021

Also experiencing this issue with @data-ui/histogram. I tried rolling back to @vx/tooltip 0.0.165 to match the dependency of data-ui/histogram, but it had no impact.

@phenry2
Copy link

phenry2 commented Jul 2, 2021

Altering

} from '@vx/tooltip/build/tooltips/TooltipWithBounds';

To read;

from "@vx/tooltip/build/enhancers/TooltipWithBounds"

Resolved the issue as withTooltopPropTypes exists here.

@kaiyoma
Copy link

kaiyoma commented Oct 19, 2021

@schwannden @phenry2 Have you found a fix or workaround here? I'm upgrading to webpack 5 and now I'm starting to run into this as well.

@phenry2
Copy link

phenry2 commented Oct 19, 2021

Sorry, I gave up and switched to a completely different package in the end. Everything I tried seemed to make it worse.

@kaiyoma
Copy link

kaiyoma commented Oct 19, 2021

I was able to hack around this problem following the suggestion here: #208 (comment)

The imports should look like this:

import TooltipWithBounds from '@vx/tooltip/build/tooltips/TooltipWithBounds';
import { withTooltipPropTypes as vxTooltipPropTypes } from '@vx/tooltip/build/enhancers/withTooltip';

I pushed a custom fork (with only the above fix) to our internal registry and that was enough to get past my most immediate obstacle. Agreed that the appropriate long-term strategy is to ditch data-ui entirely.

@ninjaasmoke
Copy link

Sorry, I gave up and switched to a completely different package in the end. Everything I tried seemed to make it worse.

Hey, what package did you switch to?

@phenry2
Copy link

phenry2 commented Feb 8, 2022

Start using carbon charts, they have a nice histogram. https://github.com/carbon-design-system/carbon-charts

Sorry, I gave up and switched to a completely different package in the end. Everything I tried seemed to make it worse.

Hey, what package did you switch to?

Start using carbon charts, they have a nice histogram. https://github.com/carbon-design-system/carbon-charts

@nth-zik
Copy link

nth-zik commented Jul 13, 2022

Start using carbon charts, they have a nice histogram. https://github.com/carbon-design-system/carbon-charts

Sorry, I gave up and switched to a completely different package in the end. Everything I tried seemed to make it worse.

Hey, what package did you switch to?

Start using carbon charts, they have a nice histogram. https://github.com/carbon-design-system/carbon-charts

It's not a solution to this issue 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants