Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write basic tests for HyperOptArgumentParser #18

Open
williamFalcon opened this issue Mar 22, 2018 · 2 comments
Open

Write basic tests for HyperOptArgumentParser #18

williamFalcon opened this issue Mar 22, 2018 · 2 comments

Comments

@williamFalcon
Copy link
Owner

williamFalcon commented Mar 22, 2018

Initial tests should include:

  • Testing grid search generation
  • Testing random search generation
  • CPU parallelization
  • GPU parallelization
  • Releasing free GPUs and CPUs continuously so there isn't idle time on either
@yuqli
Copy link

yuqli commented Nov 25, 2018

I claimed to contribute to the "writing tests for log.py issue" a few weeks ago but just got started, and soon realize it might be helpful to understand argparse_hopt.py first as the Experiment class depends on it.

I have been trying to read the source code for the past two days and sort of understand the Experiment class now, but it would be great if you could kindly help offer some comments on the general purpose of the following classes in the argparse_hopt.py script... I'm not sure I entirely got what's happening in this file.

  • HyperOptArgumentParser class : why do you need this class to collect arguments (I guess), when you will parse the arguments in the log.py test with a parse method of the Experiment class later?
  • TTNamespace : what's the purpose of this class?
  • OptArg: is this class adjusting range of arguments?

Also, is hyperopt.py obsolete? It seems not being used anywhere or I might be missing something.

Thanks a lot!

@williamFalcon
Copy link
Owner Author

hyperopt.py is deprecated.
TTNamespace is a weird python object for holding key-value pairs.
OptArg has logic for manipulating a parameter
HyperOptArgumentParser not sure what you're asking. This class is there for convenience to the user.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants