This repository has been archived by the owner on Apr 6, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Add property for dbus unit path and add get_service* Manager helper m… #2
Open
vtsingaras
wants to merge
12
commits into
wiliamsouza:master
Choose a base branch
from
vtsingaras:add_accessors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 LGTM |
We can chat together on freenode #python-br |
@wiliamsouza was that directed to me or bartgee? |
We can chat there, Wiliam. What time is suitable for you? Let's say 9:00 PM UTC will be good or too early for you? |
Python3 support and package renaming
@vtsingaras Can you fix the conflicts? Sorry for the delay on this PR About the chat just saying where you can find me Another thing I have no experience testing this type of software but it would be nice to have some. what do you guys think? |
I will have fixed the conflicts by Saturday (probably will do this on Thursday). |
@wiliamsouza I fixed the conflicts on Friday. Writing here so that you get a notification (not sure if github sends one on every push) |
@wiliamsouza I'd be great if you could merge this PR, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ethods