[Helm Charts] Add support for configuring Kubernetes startup probe via … #645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
stability-level/default
github-actions
bot
added
stability-level/default
github-actions
bot
added
stability-level/default
github-actions
bot
added
stability-level/default
laDok8
reviewed
Nov 5, 2024
| The alternative to those issues is to have the ability to configure a Startup Probe. The Startup Probe can be used to delay the initial checks done by the liveness and readiness probes, allowing some configuration without compromising them. | ||
|
|
||
| The goal of this RFE is to define the default initial configuration of a Startup Probe so users can tweak it when required. | ||
|
|
There was a problem hiding this comment.
Suggested change
| For consistency sake same configuration shall also be introduced for liveness and readiness probes |
There was a problem hiding this comment.
@laDok8 Notice that there was already a default configuration for the liveness and readiness probes in the Helm Chart. See the changes we added in this proposal: https://github.com/wildfly/wildfly-charts/pull/34/files
I don't mind tracking them as they were added with this proposal, and indeed, it is completely harmless and only paperwork, but I want to be clear that there were already default values for the aforementioned probes.
Are you following me on this? If so, to avoid any bikeshedding on this, I plan to accept your good suggestions, but first I would like to be sure we are on the same page about this.
laDok8
reviewed
Nov 5, 2024
Comment on lines
+91
to
+100
| * The proposal for the default Startup Probe configuration is the following: | ||
| + | ||
| [source,yaml] | ||
| startupProbe: | ||
| httpGet: | ||
| path: /health/live | ||
| port: admin | ||
| initialDelaySeconds: 5 | ||
| failureThreshold: 36 | ||
| periodSeconds: 5 |
There was a problem hiding this comment.
Suggested change
| * The proposal for the default Startup Probe configuration is the following: | |
| + | |
| [source,yaml] | |
| startupProbe: | |
| httpGet: | |
| path: /health/live | |
| port: admin | |
| initialDelaySeconds: 5 | |
| failureThreshold: 36 | |
| periodSeconds: 5 | |
| * The proposal for the default configurations is following: | |
| + | |
| [source,yaml] | |
| livenessProbe: | |
| httpGet: | |
| path: /health/live | |
| port: admin | |
| readinessProbe: | |
| httpGet: | |
| path: /health/ready | |
| port: admin | |
| startupProbe: | |
| httpGet: | |
| path: /health/live | |
| port: admin | |
| initialDelaySeconds: 5 | |
| failureThreshold: 36 | |
| periodSeconds: 5 |
laDok8
reviewed
Nov 5, 2024
cloud/EAP7-1769-Helm-cahrts-Configuring-Kubernetes-startup-probe.adoc
Outdated
Show resolved
Hide resolved
laDok8
reviewed
Nov 5, 2024
|
|
||
| == Release Note Content | ||
|
|
||
| Added the ability to configure a Startup Probe using WildFly Helm Charts. |
There was a problem hiding this comment.
Suggested change
| Added the ability to configure a Startup Probe using WildFly Helm Charts. | |
| Increased default timeouts for startup, readiness and liveness probes and added the ability to configure a these probes using WildFly Helm Charts. |
There was a problem hiding this comment.
Why Increased default timeouts for startup, readiness and liveness probes if we are not adding any specific configuration for readiness and liveness?
…be.adoc Co-authored-by: laDok8 <[email protected]>
github-actions
bot
added
stability-level/default
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Helm Charts
Issue: wildfly/wildfly-charts#37
Resolves #646
CC @laDok8