[WFLY-19371] helloworld-singleton Quickstarts should have a root webpage similar to helloworld #922
Conversation
|
Hi @sudeshnas93. Thanks for your PR. I'm waiting for a wildfly member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
| <html> | ||
| <html lang="en"> |
There was a problem hiding this comment.
There are 2 <html> tags. You just need one.
There was a problem hiding this comment.
Rectified the mistake.
| @@ -54,6 +54,6 @@ public void testHTTPEndpointIsAvailable() throws IOException, InterruptedExcepti | |||
| final HttpResponse<String> response = client.send(request, HttpResponse.BodyHandlers.ofString()); | |||
| Assertions.assertEquals(200, response.statusCode()); | |||
| final String[] bodyLines = response.body().toString().split(System.lineSeparator()); | |||
| Assertions.assertEquals("<meta http-equiv=\"Refresh\" content=\"0; URL=home.jsf\">", bodyLines[bodyLines.length-3]); | |||
| Assertions.assertEquals("</div>", bodyLines[bodyLines.length-3]); | |||
There was a problem hiding this comment.
I'd recommend asserting line 23 instead of line 33.
There was a problem hiding this comment.
made the required changes. Thanks.
| <head> | ||
| <meta http-equiv="Refresh" content="0; URL=home.jsf"> | ||
| <meta charset="UTF-8"> | ||
| <title>helloworld singleton</title> | ||
| </head> | ||
| </html> |
…age similar to helloworld
Issue: https://issues.redhat.com/browse/WFLY-19371
Linked Issue: https://issues.redhat.com/browse/WFLY-19075