Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group collectable data into a struct rather than having different variables #2

Open
JasoonS opened this issue Sep 26, 2019 · 0 comments

Comments

@JasoonS
Copy link
Member

JasoonS commented Sep 26, 2019

Currently the each variable relating to a token is in its own mapping. It could be more efficient to make a single collectable 'struct' to store all these variables. (for a single map lookup in functions that use/modify multiple variables).

Just a thought about a potential downside, if we use ZeppelinOS for upgradability, then we won't be able to modify the shape of that struct. But we could keep on adding new mappings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant