Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested updates to Reviewer Checklist for "new pathway submission" PRs #27

Open
7 tasks
khanspers opened this issue Oct 21, 2024 · 0 comments
Open
7 tasks

Comments

@khanspers
Copy link
Member

Below are some suggestions for updates to the Reviewer Checklist for "new pathway submission" PRs.

  • This assumes that it's possible to have different check lists for "new" and "updated" PRs
  • The proposed new language for each item in the checklist is in the style of a task. I'm not sure if this is helpful, open to feedback.
  • Reviewers can refer to the Automated Testing section to see results of automated tests, and maybe also some output from specific tests? For example, for the data node annotation test can we include a list of data nodes (node labels) with failed database lookup?
  • Some items reference tests that don't exist yet, so I made up numbers.

Reviewer Checklist

  • Review the pathway title for relevance to the pathway content.
  • Review the description for relevance to the pathway content, completeness and grammar.
  • Review data node annotations: see incomplete node annotations under Automated Testing, test 5 results.
  • Review interactions: see unconnected interactions under Automated Testing, test 6 results.
  • Review source references for relevance.
  • Review ontology terms for relevance.
  • Review pathway diagram layout and style.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant