From 9ec267614feda1203798296f4a76836eba613725 Mon Sep 17 00:00:00 2001
From: Ayushi Agrawal
 <88406934+ayushi-agrawal-gladstone@users.noreply.github.com>
Date: Thu, 19 Sep 2024 17:08:58 -0700
Subject: [PATCH] check modified or deleted nodes

---
 .github/workflows/1_on_pull_request.yml | 36 ++++++++++++++++++++-----
 1 file changed, 30 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/1_on_pull_request.yml b/.github/workflows/1_on_pull_request.yml
index acbaf119..04404966 100644
--- a/.github/workflows/1_on_pull_request.yml
+++ b/.github/workflows/1_on_pull_request.yml
@@ -878,14 +878,38 @@ jobs:
         diff_output=$(cat diff_output.txt)
         
         # Extract nodes that were removed from the GPML file (lines starting with '-')
-        deleted_nodes=$(echo "$diff_output" | grep "^-" | grep '<DataNode')
+        deleted_nodes=$(echo "$diff_output" | grep "^-" | grep '<DataNode' | sed 's/^-//')
+        
+        # Extract nodes that were added or changed in the GPML file (lines starting with '+')
+        added_or_modified_nodes=$(echo "$diff_output" | grep "^+" | grep '<DataNode' | sed 's/^+//')
+        
+        # Check for matching GraphId in both deleted and added/modified nodes to determine if it was modified
+        modified_nodes=""
+        for deleted_node in $deleted_nodes; do
+          graph_id=$(echo "$deleted_node" | grep -o 'GraphId="[^"]*"' | sed 's/GraphId="//;s/"//')
+          if echo "$added_or_modified_nodes" | grep -q "GraphId=\"$graph_id\""; then
+            modified_nodes="$modified_nodes\n$deleted_node"
+          fi
+        done
     
-        if [ -z "$deleted_nodes" ]; then
-          echo "No nodes were deleted."
+        # Remove modified nodes from the deleted nodes list
+        actual_deleted_nodes=$(echo "$deleted_nodes" | grep -v -f <(echo "$modified_nodes"))
+    
+        # Output the results
+        if [ -z "$actual_deleted_nodes" ] && [ -z "$modified_nodes" ]; then
+          echo "No nodes were deleted or modified."
         else
-          echo "Deleted nodes:"
-          echo "$deleted_nodes"
-          echo "Note: Review required for deleted nodes."
+          if [ -n "$actual_deleted_nodes" ]; then
+            echo "Deleted nodes:"
+            echo "$actual_deleted_nodes"
+            echo "Note: Review required for deleted nodes."
+          fi
+          
+          if [ -n "$modified_nodes" ]; then
+            echo "Modified nodes:"
+            echo "$modified_nodes"
+            echo "Note: Review required for modified nodes."
+          fi
         fi
     
         # Store the deleted nodes as an environment variable for later use