Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hyperlinks in descriptions #10

Open
danidi opened this issue Sep 1, 2022 · 4 comments
Open

Hyperlinks in descriptions #10

danidi opened this issue Sep 1, 2022 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@danidi
Copy link

danidi commented Sep 1, 2022

https://new.wikipathways.org/pathways/WP4792.html contains two links in the description. On the old page, they were clickable, here it seems they are not correctly formatted to be a clickable link.

@AlexanderPico
Copy link
Member

Good catch! @mkutmon Is this something we could translate as part of the metadata action? Basically, we need to detect (by grep) mediawiki markdown for links (e.g., [https://link.com text]) and translate to html (e.g., <a href="https://link.com" target="_blank">text</a>).

@AlexanderPico AlexanderPico added the bug Something isn't working label Sep 1, 2022
@Chris-Evelo
Copy link

This makes me think we could do CURIE (compact identifier) support as well? That would mean detecting a CURIE for what it is, like UNIPROT:P12345. And then use, ideally, a resolver like identifiers.org or nt2.net to go to the actual link (so we do not have to support resolving, just have a standard way to go to the resolver instead).

@AlexanderPico
Copy link
Member

AlexanderPico commented Sep 2, 2022

Great minds think alike :) Egon, Helena and I just implemented this for the "Participants" table on the new site. The code is all on place, but the CURIES just need to be fixed for the links to actually work properly. Should be working by next week.

For example, the table includes ncbigene:1234 and the new Jekyll site turns that into https://bioregistry.io/ncbigene:1234.

@khanspers khanspers transferred this issue from wikipathways/wikipathways.github.io Sep 7, 2022
@AlexanderPico AlexanderPico self-assigned this Mar 2, 2023
@khanspers
Copy link
Member

It seems this issue is in the wrong repo (I originally moved it here), and should probably be in https://github.com/wikipathways/meta-data-action. Transferring.

@khanspers khanspers transferred this issue from wikipathways/wikipathways-help Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants