Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scale a cell boundary, the spacing between lines does not scale correctly #57

Open
AlexanderPico opened this issue Nov 3, 2017 · 4 comments
Open

Scale a cell boundary, the spacing between lines does not scale correctly #57

AlexanderPico opened this issue Nov 3, 2017 · 4 comments
Assignees
@AlexanderPico @mkutmon
Labels
bug

Comments

@AlexanderPico
Copy link
Member

Want to try switching from paths to shapes...
@AdamStuart
Copy link
Contributor

DelayedVizProp # 474 defines getShape(String propvalue)
which calls makeRoundRect (#576) and makeEllipse (#533) which need rethinking.

@AlexanderPico
Copy link
Member Author

https://github.com/wikipathways/cytoscape-wikipathways-app/blob/develop/src/main/java/org/wikipathways/cytoscapeapp/impl/DelayedVizProp.java#L474

AlexanderPico added a commit that referenced this issue Nov 5, 2017
@AlexanderPico
Working on #57: separated cell and nucleus from roundrect and ovals
5ec78ad
@AlexanderPico AlexanderPico added this to the 3.3 milestone Nov 5, 2017
AlexanderPico added a commit that referenced this issue Nov 6, 2017
@AlexanderPico
fixes cell drawing for #57
2dfb497
AlexanderPico added a commit that referenced this issue Nov 6, 2017
@AlexanderPico
sorta helps fix #57; gap still dependent on scaling
7db3308
@AlexanderPico
Copy link
Member Author

Sort helped by making scaling symmetrical within x or y, but scaling is still asymmetrical between x and y...

7db3308

Probably can't be done with general path. maybe two shapes? or a thin white line over a thick gray line?

@AlexanderPico AlexanderPico removed this from the 3.3.0 milestone Mar 28, 2018
@AlexanderPico
Copy link
Member Author

For example WP1539

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexanderPico AlexanderPico

@mkutmon mkutmon

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@AlexanderPico @mkutmon @AdamStuart