From 9d66d6badbce132909c4a8e8db1cd97cf0a631ab Mon Sep 17 00:00:00 2001 From: eamedina Date: Thu, 13 Jun 2024 11:37:40 -0400 Subject: [PATCH 1/5] Fix footer and add min-height to preview --- src/link/style.scss | 35 ++++++++++++++++++++++++++--------- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/src/link/style.scss b/src/link/style.scss index af15046..5c08148 100644 --- a/src/link/style.scss +++ b/src/link/style.scss @@ -351,6 +351,7 @@ body { .wikipediapreview-edit-preview { width: 350px; + min-height: 214px; &-container { display: flex; @@ -423,20 +424,36 @@ body { } .wikipediapreview-footer { + position: relative; + display: flex; + align-items: center; + justify-content: center; + height: 40px; + z-index: 5; - &-cta-readmore { - display: none; - } + &-link { + margin-right: 5px; + + &-cta { + text-decoration: none; + font-size: 14px; + color: #36c; + margin-right: 4px; + + &:hover { + text-decoration: underline; + } - &-cta-readonwiki { - display: block; + &:visited { + color: #6B4BA1; + svg path { + fill: #6B4BA1; + } + } + } } } } - - .wikipediapreview-body::after { - content: none; - } } &.is-expanded { From 581501b9a2c8596de9f356dac307678cc0bbff95 Mon Sep 17 00:00:00 2001 From: eamedina Date: Thu, 13 Jun 2024 12:01:58 -0400 Subject: [PATCH 2/5] Fix header title text overflow --- src/link/sections.js | 4 +++- src/link/style.scss | 9 +++++++++ 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/src/link/sections.js b/src/link/sections.js index d0d5503..44fb4c3 100644 --- a/src/link/sections.js +++ b/src/link/sections.js @@ -84,7 +84,9 @@ export const Sections = ( { return (
- { titleWithoutSection( activeAttributes.title ) } +
+ { titleWithoutSection( activeAttributes.title ) } +
setSelectingSection( false ) } diff --git a/src/link/style.scss b/src/link/style.scss index 5c08148..c93d475 100644 --- a/src/link/style.scss +++ b/src/link/style.scss @@ -570,6 +570,15 @@ body { border-bottom: 1px solid #c8ccd1; justify-content: space-between; + &-title { + max-width: 90%; + text-overflow: ellipsis; + display: -webkit-box; + -webkit-line-clamp: 2; + -webkit-box-orient: vertical; + overflow: hidden; + } + &-close { background-image: url(./images/close-language.svg); width: 20px; From 9a8363f5770bd7eb3bfc9defa02df232bca03894 Mon Sep 17 00:00:00 2001 From: eamedina Date: Thu, 13 Jun 2024 12:20:40 -0400 Subject: [PATCH 3/5] Update header styling --- src/link/images/close-sections.svg | 3 +++ src/link/style.scss | 5 +++-- 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 src/link/images/close-sections.svg diff --git a/src/link/images/close-sections.svg b/src/link/images/close-sections.svg new file mode 100644 index 0000000..442d7fc --- /dev/null +++ b/src/link/images/close-sections.svg @@ -0,0 +1,3 @@ + + + diff --git a/src/link/style.scss b/src/link/style.scss index c93d475..95c2e72 100644 --- a/src/link/style.scss +++ b/src/link/style.scss @@ -564,7 +564,7 @@ body { min-height: 70px; display: flex; align-items: center; - padding: 0 10px 0 10px; + padding: 0 16px 0 16px; font-size: 16px; font-weight: bold; border-bottom: 1px solid #c8ccd1; @@ -577,10 +577,11 @@ body { -webkit-line-clamp: 2; -webkit-box-orient: vertical; overflow: hidden; + color: #202122 } &-close { - background-image: url(./images/close-language.svg); + background-image: url(./images/close-sections.svg); width: 20px; height: 20px; cursor: pointer; From c21e4e3be5f3ee5b5e654e4e0e9533e12a91a755 Mon Sep 17 00:00:00 2001 From: eamedina Date: Thu, 13 Jun 2024 12:23:23 -0400 Subject: [PATCH 4/5] Update list item style --- src/link/style.scss | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/link/style.scss b/src/link/style.scss index 95c2e72..632f318 100644 --- a/src/link/style.scss +++ b/src/link/style.scss @@ -595,8 +595,8 @@ body { &-item { display: flex; align-items: center; - padding: 5px; - margin: 5px; + padding: 4px; + margin: 8px; &-content { display: flex; From 8da7470834dd27a2ffc816ecdba2db81299a977c Mon Sep 17 00:00:00 2001 From: eamedina Date: Fri, 21 Jun 2024 16:09:12 -0400 Subject: [PATCH 5/5] Only one close icon for views --- src/link/images/close-language.svg | 3 --- src/link/images/{close-sections.svg => close-view.svg} | 0 src/link/style.scss | 4 ++-- 3 files changed, 2 insertions(+), 5 deletions(-) delete mode 100644 src/link/images/close-language.svg rename src/link/images/{close-sections.svg => close-view.svg} (100%) diff --git a/src/link/images/close-language.svg b/src/link/images/close-language.svg deleted file mode 100644 index 2b14070..0000000 --- a/src/link/images/close-language.svg +++ /dev/null @@ -1,3 +0,0 @@ - - - diff --git a/src/link/images/close-sections.svg b/src/link/images/close-view.svg similarity index 100% rename from src/link/images/close-sections.svg rename to src/link/images/close-view.svg diff --git a/src/link/style.scss b/src/link/style.scss index 632f318..f378ddb 100644 --- a/src/link/style.scss +++ b/src/link/style.scss @@ -220,7 +220,7 @@ body { line-height: 19.55px; &-close { - background-image: url(./images/close-language.svg); + background-image: url(./images/close-view.svg); width: 20px; height: 20px; cursor: pointer; @@ -581,7 +581,7 @@ body { } &-close { - background-image: url(./images/close-sections.svg); + background-image: url(./images/close-view.svg); width: 20px; height: 20px; cursor: pointer;