Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relative URLs #74

Open
kevinahuber opened this issue Feb 13, 2018 · 1 comment
Open

Relative URLs #74

kevinahuber opened this issue Feb 13, 2018 · 1 comment

Comments

@kevinahuber
Copy link
Contributor

OG allows for image URLs that are relative paths. The debugger automatically prepends the domain to relative paths.. I've seen this done with other metadata as well.. whether it is specifically allowed in a spec or not. It would be helpful for this package to identify and replace those cases. Is it within the scope of this package to cover that? If so, I am happy to make a contribution!

@mvolz
Copy link
Collaborator

mvolz commented Feb 14, 2018

I think that sounds good! I think it should be made optional (i.e. in the individual methods, if the url is added as a second arg, then use it create the full urls, but if not, just include the relative paths).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants