Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Browserify #24

Open
martindale opened this issue Jul 20, 2015 · 1 comment
Open

Support Browserify #24

martindale opened this issue Jul 20, 2015 · 1 comment

Comments

@martindale
Copy link

This is a wonderful module, but it seems difficult to browserify (CORS being the a least one of your concerns). Perhaps we use something other than Cheerio for a browser context?

@mvolz
Copy link
Collaborator

mvolz commented Jul 23, 2015

We were considering using domino for expense reasons, but have temporarily tabled it due to an external library using cheerio (the schema.org one)- we'd have to do our own implementation of that library before switching. Would domino be easier to browserify? That is something that could potentially happen.

We don't currently have an internal use for making it browserifiable generally though so it would probably not happen in the near future unless of course you'd like to fork/implement it yourself- always happy to take pull requests to make the library more useful :)!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants