Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AfCH script not working #71

Closed
ghost opened this issue Dec 17, 2015 · 8 comments
Closed

AfCH script not working #71

ghost opened this issue Dec 17, 2015 · 8 comments
Labels
C-bug Category: bug

Comments

@ghost
Copy link

ghost commented Dec 17, 2015

After selecting "Review (AFCH)" from the dropdown menu, the traditional three-button window appears but none of the buttons or links react when clicked. (So "Accept", "Decline", "Comment", "Clean submission" and "Mark as under review" aren't working.)

Let me know if more information is needed.
@hasteur
Copy link

hasteur commented Dec 17, 2015

Were there any errors on the JS console? What page were you trying to
review?
On Dec 17, 2015 4:44 PM, "wiawikipedia" [email protected] wrote:

After selecting "Review (AFCH)" from the dropdown menu, the traditional
three-button window appears but none of the buttons or links react when
clicked (So "Accept", "Decline", "Comment", "Clean submission" and "Mark as
under review" aren't working)

Let me know if more information is needed

—
Reply to this email directly or view it on GitHub
#71.

@josve05a
Copy link
Contributor

On all drafts.
screenshot 2015-12-17 at 23 50 07

Uncaught TypeError: Cannot read property 'get' of undefinedMwMessagePosterFactory.create @ VM124:34

MwFeedback @ VM124:35

$.extend.initFeedback @ VM123:778

(anonymous function) @ VM152:821

(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47

fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45

self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46

(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:48

fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45

self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46

deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47

(anonymous function) @ VM152:73
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45

self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46

deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47

(anonymous function) @ VM123:931
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45

self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46

deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47

(anonymous function) @ VM123:850
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45

self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46

deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47

(anonymous function) @ VM123:1119
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45

self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46

deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47

(anonymous function) @ VM93:3
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45

self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46

done @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:135

callback @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:141

@hasteur
Copy link

hasteur commented Dec 17, 2015

The buttons fail because the JavaScript croaked while loading. I'm mobile
right now so cant see if this is localized to you or if this is widespread.
On Dec 17, 2015 4:50 PM, "Jonatan Svensson Glad" [email protected]
wrote:

On all drafts.
[image: screenshot 2015-12-17 at 23 50 07]
https://cloud.githubusercontent.com/assets/7117013/11884286/eb8fce0c-a518-11e5-9c2b-17302101f941.png

Uncaught TypeError: Cannot read property 'get' of undefinedMwMessagePosterFactory.create @ VM124:34
MwFeedback @ VM124:35$.extend.initFeedback @ VM123:778
(anonymous function) @ VM152:821
(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46
(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:48
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46
deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47
(anonymous function) @ VM152:73
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46
deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47
(anonymous function) @ VM123:931
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46
deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47
(anonymous function) @ VM123:850
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46
deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47
(anonymous function) @ VM123:1119
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46
deferred.(anonymous function) @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:47
(anonymous function) @ VM93:3
fire @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:45self.fireWith @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:46
done @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:135
callback @ load.php?debug=false&lang=en&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=%2Ba17lhsh:141

—
Reply to this email directly or view it on GitHub
#71 (comment).

@josve05a
Copy link
Contributor

It is confirmed on IRC that this is widespread for everyone. Using beta as a fallback as of right now.

@theopolisme
Copy link
Contributor

Looking...

theopolisme added a commit that referenced this issue Dec 17, 2015
@theopolisme
Disable feedback due to #71
33571bb
@theopolisme
Copy link
Contributor

I've implemented a temporary fix and pushed it to enwiki. Please try clearing your cache and do comment here if the issue continues.

Leaving this issue open until I figure out what went wrong with mwFeedback...

@theopolisme theopolisme added the C-bug Category: bug label Dec 17, 2015
@theopolisme
Copy link
Contributor

On enwiki: https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation/Helper_script#Draft:_Dixien_LLC

@NovemLinguae
Copy link
Member

This code has been commented out for 9 years. I plan to delete it as dead code in patch #351. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hasteur @theopolisme @josve05a @NovemLinguae