Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy comments to article's talk page when accepting #128

Closed
enterprisey opened this issue Jan 17, 2021 · 8 comments · Fixed by #223
Closed

Copy comments to article's talk page when accepting #128

enterprisey opened this issue Jan 17, 2021 · 8 comments · Fixed by #223
Labels
C-enhancement Category: enhancement frequently-requested Requested by different people on different occasions

Comments

@enterprisey
Copy link
Contributor

Very long-standing request.

Second, when [a] draft is accepted, would it be possible to copy the AFC comments to the talk page, or to give the reviewer the option of copying them to the talk page? Sometimes they call for improvements to the article, and sometimes they call for improvements to another article (such as including the name of the subject of the article in a disambiguation list of people with the same name).

Requested by Robert McClenon on 04:00, 27 October 2020 (UTC)
Archive link: https://en.wikipedia.org/wiki/Wikipedia_talk:WikiProject_Articles_for_creation/2020_4#Script_Addition_Requests

@enterprisey enterprisey added C-enhancement Category: enhancement E-good-first-issue Experience needed: zero (good first issue) frequently-requested Requested by different people on different occasions labels Jan 17, 2021
@primefac
Copy link

Automatic, no; quite often the comments are nothing more than indicating what needs improving.

@enterprisey
Copy link
Contributor Author

The advanced version of this would probably be a checkbox UI showing a list of all the comments and checkboxes specifying whether to copy over each one. Quite possibly not worth the additional effort, though.

@enterprisey enterprisey removed the E-good-first-issue Experience needed: zero (good first issue) label Jan 17, 2021
@primefac
Copy link

That's an interesting idea! I do think it would likely be more hassle than it's worth, though; the comments are (if I understand those who want this done) being kept mainly for historical reasons over any sort of "ongoing discussion" concerns.

@robertsky
Copy link
Contributor

if implemented, when copying over to the talk page, the Afc comment template should be subst as well. No point leaving them encapsulated when it is in the talk page for historical purposes.

@primefac
Copy link

Agreed with the subst. This might be an obvious statement, but they should probably be in a new section as well, with the header being something like "Pre-accept reviewer comments" or something similar, to indicate their provenance.

@NovemLinguae
Copy link
Member

@NovemLinguae
Copy link
Member

I do think it would likely be more hassle than it's worth, though

Looks like Primefac has updated their opinion a bit. Here's the latest:

I'm going to add in ''my'' perennial reply to this request that if/when this is implemented (which for the record, I generally support) it should be opt-in (i.e. check-boxed), as I rarely find reason to keep the comments left by reviewers.

@primefac
Copy link

primefac commented Jul 19, 2023

I would argue that's the same opinion, just worded differently ;-)

I don't know if I've ever been really "opposed" to this suggestion, just (per the latter part of the latter quote) don't really see the use in most cases. But I'm not the one doing the coding, so there!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-enhancement Category: enhancement frequently-requested Requested by different people on different occasions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants