Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jquery-ui] conflicting webjar #954

Open
solomax opened this issue Jun 26, 2024 · 6 comments
Open

[jquery-ui] conflicting webjar #954

solomax opened this issue Jun 26, 2024 · 6 comments
Assignees

Comments

@solomax
Copy link
Contributor

solomax commented Jun 26, 2024

Our project uses both wicketstuff-jquery-ui and wicket-bootstrap

one of them uses

[INFO] +- org.wicketstuff:wicketstuff-jquery-ui-core:jar:10.1.1:compile
[INFO] |  \- org.webjars.npm:moment:jar:2.30.1:compile

the other one uses:

[INFO] +- de.agilecoders.wicket:wicket-bootstrap-extensions:jar:7.0.5:compile
[INFO] |  +- org.webjars:momentjs:jar:2.29.4:compile

So I got 2 versions of momenjs same time

Webjars is unable to work in such situation

IMO these versions should be aligned @martin-g WDYT should I update wicketstuff or wicket-bootstrap?

@solomax solomax self-assigned this Jun 26, 2024
@reckart
Copy link
Contributor

reckart commented Jun 26, 2024

Why does Maven not resolve this to the latest (closest) version?

@reckart
Copy link
Contributor

reckart commented Jun 26, 2024

Ah - different groupIDs. It would be good to align the groupIDs.

@solomax
Copy link
Contributor Author

solomax commented Jun 26, 2024

both groupId and artifactId differs :(

@martin-g
Copy link
Member

martin-g commented Jun 27, 2024

IMO these versions should be aligned @martin-g WDYT should I update wicketstuff or wicket-bootstrap?

Honestly I have no idea what is the difference between those two ways of packaging ...

If both work for our needs then I'd suggest to use the dependency that is newer, i.e. (org.webjars.npm:moment:jar:2.30.1).

@solomax
Copy link
Contributor Author

solomax commented Jun 27, 2024

GroupID = org.webjars
ArtifactID = momentjs
Version = 2.30.1

was just generated and deployed :)))

I'll update wicketstuff-core to be aligned with wicket-bootstrap (also need to fix some other issues :)))

@solomax
Copy link
Contributor Author

solomax commented Jun 27, 2024

Unfortunately this fix should be reverted :(

For whatever reason org.webjars:momentjs doesn't contains required files :(

I'll create PR for wicket-bootstrap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants