Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screenshots #3

Open
whyboris opened this issue Jun 26, 2020 · 4 comments
Open

Screenshots #3

whyboris opened this issue Jun 26, 2020 · 4 comments

Comments

@whyboris
Copy link
Owner

Please share beautiful screenshots below πŸ™‡β€β™‚οΈ

This repository is still WIP 🚧 feel free to suggest other visualizations (and visualization libraries) for this project 🀝

@whyboris
Copy link
Owner Author

WIP screenshot for the repository:
image

@johnsoncodehk
Copy link
Contributor

Thanks for this project, very helpful for refactoring!

Here are two suggestions:

  • Add a toggle to switch whether to combine same function names.
  • For asynchronous call (e.g. setTimeout(() => foo())), replace the solid line with a dotted line.

screencapture-localhost-3000-cascade-index-html-2020-08-05-04_49_28

@whyboris
Copy link
Owner Author

whyboris commented Aug 6, 2020

So cool! Thank you for the screenshot!

I'm surprised there are so many duplicates πŸ€” -- for example I see unTrackingGetter is called many times -- I would have expected it to show up once! I feel like this is a bug in my code -- I don't think we need to have a toggle to show duplicates ever. I'll see if I can replicate on my end.

I like your idea about some indication of async functions (a dotted line sounds like a great way to do it).

I'm open to any PRs -- I've been focusing more on my Video Hub App these days πŸ˜…

@johnsoncodehk
Copy link
Contributor

I think this is not an error. I did call it multiple times, but I aimed to check the dependency of the function, so it would be helpful to provide the option to merge the same function.
I still have a lot of work in progress. If I have time, I will try to solve the problem that functions of the same name in different scripts will be regarded as the same function. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants