Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change !send reply [msgid] to !reply [msgid] #46

Open
jcserv opened this issue Jun 2, 2021 · 3 comments
Open

Change !send reply [msgid] to !reply [msgid] #46

jcserv opened this issue Jun 2, 2021 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jcserv
Copy link
Contributor

jcserv commented Jun 2, 2021

What problem are you facing?

!send reply [msgid] feels unnecessarily long

What can we do to fix that problem?

Change it to be !reply [msgid]
Only downside I can think of right now is any possible code duplication between the cases, but it'd also let us remove some command parsing logic.

Another issue: users may be used to the syntax of !send reply

Few options:

  1. Make a full change and make an announcement
  2. Implement the shortened command while keeping the old one, and remove it in the next release so that users are acclimated
  3. If they use "send reply", send a help message telling them it has changed
@jcserv jcserv added the enhancement New feature or request label Jun 2, 2021
@Yousef-Bulbulia
Copy link
Member

Good idea! I'm in favour of making an announcement of the change, as well as sending them a help message telling them it's changed if they use the old syntax.

@Yousef-Bulbulia Yousef-Bulbulia added the good first issue Good for newcomers label Jun 2, 2021
@Yousef-Bulbulia
Copy link
Member

Just thought of this: using !reply msg won't work if we want to send to deep-talks, since the word "reply" replaces "send-deep". The same problem will exist for other channels once we implement scalability.

@jcserv
Copy link
Contributor Author

jcserv commented Jun 23, 2021

!reply [msgid] can work even with scalable channels, as follows:

backend:

  1. determine the channel based on the message being replied to
  2. check that the submitter has read/write permissions for that channel
  3. send the message to that channel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants