Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deleted account from group #110

Open
Schmiddiii opened this issue Mar 3, 2023 · 4 comments
Open

Remove deleted account from group #110

Schmiddiii opened this issue Mar 3, 2023 · 4 comments

Comments

@Schmiddiii
Copy link
Contributor

From testing in the Whisperfish room, one gets a 404 when sending a message to a room with a group member that disappeared. As @rubdos mentioned, presage should maybe handle that 404 and delete that user from the group.

@rubdos
Copy link
Member

rubdos commented Mar 3, 2023

@gferon if you manage to find out how Android/iOS handles a 404 here, please do let me know. I have the exact same situation in WF, and I am wondering how I should deal with it correctly.

N.b., this is not someone who disappeared from the group, rather, it's someone that deleted their Signal account altogether. Maybe they reregistered and got a new UUID, maybe something entirely different happened.

@Schmiddiii Schmiddiii changed the title Remove disappeared account from group Remove deleted account from group Mar 3, 2023
@Schmiddiii
Copy link
Contributor Author

Another ugly thing I have noticed just now: As sending the message fails with the 404, messages will not be accepted into the store.

@rubdos
Copy link
Member

rubdos commented Mar 31, 2023

@rubdos
Copy link
Member

rubdos commented Apr 1, 2023

@gferon gferon added this to the 0.5.2 milestone Apr 21, 2023
@gferon gferon removed this from the 0.5.3 milestone Nov 19, 2023
Schmiddiii added a commit to Schmiddiii/presage that referenced this issue Mar 17, 2024
This just ignores those errors when sending to a group.

Ideally, this should mark such contacts as unregistered and not send
messages to them anymore. But the store does not yet have the capability
to do that.

Related to whisperfish#110.
gferon added a commit that referenced this issue Mar 17, 2024
This just ignores those errors when sending to a group.

Ideally, this should mark such contacts as unregistered and not send
messages to them anymore. But the store does not yet have the capability
to do that.

Related to #110.
---------

Co-authored-by: Gabriel Féron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants