Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protos to add support for EditMessage #249

Merged
merged 2 commits into from
Oct 2, 2023
Merged

Conversation

gferon
Copy link
Collaborator

@gferon gferon commented Oct 2, 2023

Unfortunately, it looks like the feature to send groups as attachments (for other people to join?) was deprecated. It looks like it was a feature for GV1 anyways. @rubdos I guess you can remove that from whisperfish?

@gferon gferon requested a review from rubdos October 2, 2023 14:44
@gferon gferon marked this pull request as ready for review October 2, 2023 14:44
@gferon gferon changed the title Update protos Update protos to add support for EditMessage Oct 2, 2023
@rubdos
Copy link
Member

rubdos commented Oct 2, 2023

I guess you can remove that from whisperfish?

I don't think we have ever implemented group sync that way. Looks like a sync construction anyway. If it's an issue, I will remove it. Shouldn't be difficult.

Thanks!

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (cd20d3b) 3.73% compared to head (c417217) 3.72%.

❗ Current head c417217 differs from pull request most recent head ea42456. Consider uploading reports for the commit ea42456 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##            main    #249      +/-   ##
========================================
- Coverage   3.73%   3.72%   -0.01%     
========================================
  Files         38      38              
  Lines       2815    2817       +2     
========================================
  Hits         105     105              
- Misses      2710    2712       +2     
Files Coverage Δ
libsignal-service/src/cipher.rs 0.00% <ø> (ø)
libsignal-service/src/models.rs 0.00% <ø> (ø)
libsignal-service/src/sender.rs 0.00% <ø> (ø)
libsignal-service/src/envelope.rs 0.00% <0.00%> (ø)
libsignal-service/src/groups_v2/operations.rs 0.00% <0.00%> (ø)
libsignal-service/src/push_service.rs 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gferon gferon merged commit 454d234 into main Oct 2, 2023
8 of 9 checks passed
@gferon gferon deleted the update-protos-2 branch October 2, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants