Add server_guid to Metadata #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is unlike Signal Android, where the Envelope is also continously passed while processing the already decrypted content. In Rust, we logically would *consume* the envelope to yield the Metadata and Content, so I prefer the Metadata to contain this information.
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #243 +/- ##
========================================
- Coverage 3.67% 3.66% -0.01%
========================================
Files 38 38
Lines 2806 2808 +2
========================================
Hits 103 103
- Misses 2703 2705 +2
☔ View full report in Codecov by Sentry. |
|
Can you add a small comment in the struct to explain what this field is? |
I did just that (a few months ago, but I came across this again today)! |
|
I'm just going to pull this in, it's a rather trivial change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is unlike Signal Android, where the Envelope is also continously passed while processing the already decrypted content. In Rust, we logically would consume the envelope to yield the Metadata and Content, so I prefer the Metadata to contain this information.