Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ergonomics for the different Storage traits #92

Open
rubdos opened this issue Apr 30, 2021 · 1 comment
Open

Ergonomics for the different Storage traits #92

rubdos opened this issue Apr 30, 2021 · 1 comment

Comments

@rubdos
Copy link
Member

rubdos commented Apr 30, 2021

StoreContext extension traits, or a struct, or ... No idea, but it was a thing with our own libsignal-protocol-rs, but not anymore with libsignal-client. Would be nice to have some ergonomics about this, because the method calls are quite involved.
@rubdos rubdos mentioned this issue Apr 30, 2021
Merged
@gferon
Copy link
Collaborator

gferon commented May 2, 2021

I have tried a bunch of options when finishing !83 and I couldn't come up with anything that's really satisfying. One way to simplify the whole story could be to hide the ability to have 4 different storage engines and make an empty trait Storage: IdentityKeyStore + SessionStore + PreKeyStore + SignedPreKeyStore, since I believe that's what most people would end up doing... but it's... a hack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gferon @rubdos