Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Attachments are encrypted with synchronous code in the executor #278

Open
rubdos opened this issue Jan 8, 2024 · 1 comment
Open

Attachments are encrypted with synchronous code in the executor #278

rubdos opened this issue Jan 8, 2024 · 1 comment

Comments

@rubdos
Copy link
Member

rubdos commented Jan 8, 2024

crate::attachment_cipher::encrypt_in_place(iv, key, &mut contents) gets called synchronously, blocking the executor. This should probably go on a threadpool.
@rubdos
Copy link
Member Author

rubdos commented Jan 8, 2024

Also doesn't really make sense that encryption of attachments happens in the library, while decryption happens outside :'-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rubdos