Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not sending SyncMessage if only linked device #226

Closed
Schmiddiii opened this issue Apr 25, 2023 · 4 comments
Closed

Not sending SyncMessage if only linked device #226

Schmiddiii opened this issue Apr 25, 2023 · 4 comments

Comments

@Schmiddiii
Copy link
Contributor

If using Flare (and thus presage + libsignal-service-rs) as the only linked device to Signal Android/IOS, there is no sync message sent to the main device. I suspect that this line should also check if the device is a secondary device and then always send a SyncMessage.

This was figured out in the Flare Matrix room, at the bottom of this thread.

@rubdos
Copy link
Member

rubdos commented Apr 25, 2023

I supposed sub_device_count should handle that, but I think you're right. I wonder whether we should (again) change the get_sub_device_sessions semantics, this time to mean: return all device IDs that are not the current device. I'm not sure what Whisperfish takes as semantics there.

@gferon
Copy link
Collaborator

gferon commented Sep 26, 2023

Is this still a problem? I tested right now and it works fine.

@Schmiddiii
Copy link
Contributor Author

Sorry, I forgot to respond to this issue. I sadly cannot currently check (with the current versions of libsignal-service-rs) if this is still an issue due to the contact sync issue of presage and me not wanting to loose my linked devices that I normally use. I will check again once the contact sync issue of presage is resolved.

@Schmiddiii
Copy link
Contributor Author

Should be fixed by #262

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants