Make clippy happy

whisperfish · Apr 14, 2021 · cbc859e · cbc859e
1 parent b963d25
commit cbc859e
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/libsignal-service/src/configuration.rs b/libsignal-service/src/configuration.rs
@@ -107,10 +107,10 @@ impl ToString for SignalServers {
     }
 }
 
-impl Into<ServiceConfiguration> for SignalServers {
-    fn into(self) -> ServiceConfiguration {
+impl From<SignalServers> for ServiceConfiguration {
+    fn from(val: SignalServers) -> Self {
         // base configuration from https://github.com/signalapp/Signal-Desktop/blob/development/config/default.json
-        match self {
+        match val {
             // configuration with the Signal API staging endpoints
             // see: https://github.com/signalapp/Signal-Desktop/blob/master/config/default.json
             SignalServers::Staging => ServiceConfiguration {

diff --git a/libsignal-service/src/groups_v2/manager.rs b/libsignal-service/src/groups_v2/manager.rs
@@ -36,15 +36,14 @@ impl CredentialResponse {
     pub fn parse(
         self,
     ) -> Result<HashMap<i64, AuthCredentialResponse>, ServiceError> {
-        Ok(self
-            .credentials
+        self.credentials
             .into_iter()
             .map(|c| {
                 let bytes = base64::decode(c.credential)?;
                 let data = bincode::deserialize(&bytes)?;
                 Ok((c.redemption_time, data))
             })
-            .collect::<Result<_, ServiceError>>()?)
+            .collect::<Result<_, ServiceError>>()
     }
 }
 

diff --git a/libsignal-service/src/profile_cipher.rs b/libsignal-service/src/profile_cipher.rs
@@ -73,7 +73,7 @@ fn pad_plaintext(
     let len = brackets
         .iter()
         .find(|x| **x >= bytes.len())
-        .ok_or_else(|| ProfileCipherError::InputTooLong)?;
+        .ok_or(ProfileCipherError::InputTooLong)?;
     let len: usize = *len;
 
     bytes.resize(len, 0);

diff --git a/libsignal-service/src/sealed_session_cipher.rs b/libsignal-service/src/sealed_session_cipher.rs
@@ -199,8 +199,8 @@ impl UnidentifiedSenderMessage {
 
     fn into_bytes(self) -> Result<Vec<u8>, SealedSessionError> {
         use prost::Message;
-        let mut buf = vec![];
-        buf.push(Self::CIPHERTEXT_VERSION << 4 | Self::CIPHERTEXT_VERSION);
+        let mut buf =
+            vec![Self::CIPHERTEXT_VERSION << 4 | Self::CIPHERTEXT_VERSION];
         crate::proto::UnidentifiedSenderMessage {
             ephemeral_public: Some(
                 self.ephemeral.to_bytes()?.as_slice().to_vec(),
@@ -294,12 +294,12 @@ impl SealedSessionCipher {
             &content.into_bytes()?,
         )?;
 
-        Ok(UnidentifiedSenderMessage {
+        UnidentifiedSenderMessage {
             ephemeral: ephemeral.public(),
             encrypted_static: static_key_ciphertext,
             encrypted_message: message_bytes,
         }
-        .into_bytes()?)
+        .into_bytes()
     }
 
     pub fn decrypt(