-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should send() throw if the XHR object's window's document is not fully active? #65
Comments
Does having the check help at all? Most other APIs don't have it... |
That's the other question, yes. @smaug---- might know why we do these checks in Gecko... |
The initial reason in Gecko was https://bugzilla.mozilla.org/show_bug.cgi?id=403168 However, what should happen to the network connection if XHR is created using non-active document, like if the response is super slow, what kills it? I assume browsers normally cancel relevant network connections when unloading a page, but if the page has been unloaded already... |
@smaug---- not sure, maybe the connection is not established until such a time that the document does become active... |
Tests that other browsers not pass because of this:
Also XMLHttpRequest/open-url-multi-window-6.htm seems to not pass anywhere. I think based on this and the somewhat flawed security reason to add this initially, we should just remove this. |
Hmm, it's not that simple, Chrome will throw on |
I think the main reason the check is in |
Ran into this in jsdom as well, trying to implement the spec but failing opoen-url-multi-window-3.htm because we didn't include some kind of detached check. |
We seem to have a fully active check in open() but not send(). That doesn't make much sense to me...
The text was updated successfully, but these errors were encountered: