-
Notifications
You must be signed in to change notification settings - Fork 131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec requires firing at least two "progress" events; browsers do not. #318
Comments
domenic
added a commit
to jsdom/jsdom
that referenced
this issue
Mar 6, 2021
See whatwg/xhr#318. This fixes a broken web platform test which happens to pass in all browsers, to also happen to pass in jsdom: web-platform-tests/wpt#27917.
domenic
added a commit
to jsdom/jsdom
that referenced
this issue
Mar 6, 2021
See whatwg/xhr#318. This fixes a broken web platform test which happens to pass in all browsers, to also happen to pass in jsdom: web-platform-tests/wpt#27917.
Implementing a change in jsdom to omit the progress event revealed another non-interop, which is for zero-length response bodies: there only Firefox fires a progress event: https://wpt.fyi/results/xhr/send-no-response-event-order.htm?label=master&label=experimental&product=chrome&product=firefox&product=safari&aligned&q=send-no-response-event |
domenic
added a commit
to jsdom/jsdom
that referenced
this issue
Mar 6, 2021
See whatwg/xhr#318. This fixes a broken web platform test which happens to pass in all browsers, to also happen to pass in jsdom: web-platform-tests/wpt#27917.
domenic
added a commit
to jsdom/jsdom
that referenced
this issue
Mar 6, 2021
See whatwg/xhr#318. This fixes a broken web platform test which happens to pass in all browsers, to also happen to pass in jsdom: web-platform-tests/wpt#27917.
domenic
added a commit
to jsdom/jsdom
that referenced
this issue
Mar 6, 2021
See whatwg/xhr#318. This fixes a broken web platform test which happens to pass in all browsers, to also happen to pass in jsdom: web-platform-tests/wpt#27917.
domenic
added a commit
to jsdom/jsdom
that referenced
this issue
Mar 7, 2021
See whatwg/xhr#318. This fixes a broken web platform test which happens to pass in all browsers, to also happen to pass in jsdom: web-platform-tests/wpt#27917.
domenic
added a commit
to jsdom/jsdom
that referenced
this issue
Mar 7, 2021
See whatwg/xhr#318. This fixes a broken web platform test which happens to pass in all browsers, to also happen to pass in jsdom: web-platform-tests/wpt#27917.
domenic
added a commit
to jsdom/jsdom
that referenced
this issue
Mar 7, 2021
See whatwg/xhr#318. This fixes a broken web platform test which happens to pass in all browsers, to also happen to pass in jsdom: web-platform-tests/wpt#27917.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Example: https://boom-bath.glitch.me/xhr-small-chunks.html
The spec requires firing one as part of processResponse, and one as part of "handle response end-of-file". However, browsers only fire a single one.
As far as I can tell, they avoid firing the one in "handle response end-of-file" if the number of bytes hasn't changed. /cc @ricea in case he can make more sense of Chromium's implementation than I can.
The text was updated successfully, but these errors were encountered: