Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add .editorconfig and .gitattributes #61

Closed
wants to merge 3 commits into from
Closed

Add .editorconfig and .gitattributes #61

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eda0fbc
Add .editorconfig and .gitattributes
xfq Aug 26, 2017
5368d02
Add newline at end of file
xfq Aug 26, 2017
80d5f3d
Use two spaces for indentation of .js files
xfq Aug 29, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
root = true

[*]
end_of_line = lf
insert_final_newline = true
charset = utf-8
indent_size = 1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this means all JavaScript, CSS & HTML, etc.. indentation will be 1 space only which is bit unusual maybe we should ask @domenic in #18 about his preference.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. Currently, most (if not all) HTML files use 1 space only; JavaScript files and inline <script> elements use 2 spaces; .htaccess files are not indented consistently. And I don't think we need to worry about the indentation of SVG files in this case.

I'll wait for Domenic's reply and adjust the PR if necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 space is preferred for HTML (or SVG). I guess to be consistent we should also do it for CSS and script and .htaccess, especially since we don't use file extensions so differentiating would be tricky (see #8).

I think we should fix those files to be 1 space while merging this if you're up for it. Otherwise I think adding .editorconfig will just cause confusion since it will cause peoples' text editors to start being inconsistent with the indentation inside a file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have two spaces for .js ?

indent_style = space
trim_trailing_whitespace = true
max_line_length = 100

[.travis.yml]
indent_size = 2

[deploy.sh]
indent_size = 4
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
* text=auto