-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A '@' character in the host part of file URLs #805
Comments
It seems reasonable to allow, but I wonder if it would be possible for Chromium to determine the complete set of changes needed for it to not have platform-divergent behavior. At least I suspect that making them all at once would allow for an easier rollout. |
A single Let's take any other URL scheme, e.g. HTTP:
Which is clearly not what the reporter wants to happen. What's more, this has been the accepted interpretation for at least the last 30 years (going back to RFC-1738). I doubt many URL parsers are going to interpret I think the actual problem is that hostnames in file URLs are not able to contain percent-encoding. I looked in to this in depth a while back, and found that:
See #599 |
Please remove @ from the forbidden host code point list! Given rfc1738 it was probably a mistake that it was there in the first place. Just on this:
Firefox, Safari, windows explorer, linux terminals all handle the URL fine, in fact its only chromium based browsers that have the issue because they want to use the URL standard as their only authority, rather than use multiple path standards... |
Safari also rejects this URL, and the only reason it works in Firefox is that we currently ignore everything in the hostname part of a file URL (tracked in 1507354 - URL parser discards host for file URLs Allowing |
@valenting yes I think the problem is calling them file URLs, they are URL like but ultimately the OP (file://webdavserver.net@ssl/a.pdf) is a UNC file path, and currently its just a coincidence that Chromium works for most of them... |
(Reported in https://crbug.com/1502849)
It appears that Windows uses file URLs with '@' (U+0040) characters in their host parts, such as
file://webdavserver.net@ssl/a.pdf
.However, according to my understanding,
file://webdavserver.net@ssl/a.pdf
is an invalid URL in the URL Standard because '@' is considered a forbidden host code point.To ensure compatibility with Windows file URLs, should we consider allowing the '@' character in the host part of file URLs?
I'd appreciate hearing opinions of the URL Standard folks on this matter.
The text was updated successfully, but these errors were encountered: